Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 28721a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
thomaswhyyou
force-pushed
the
thomas-kno-11523-sdk-clean-up-trackdebugparams-once-we-ship-toolbar-v2
branch
from
6a5d677 to
09c169d
Compare
thomaswhyyou
force-pushed
the
thomas-kno-12634-toolbar-rename-stageresults-keys-to-bykey-and-bytype
branch
from
f99231d to
34f8bb6
Compare
thomaswhyyou
force-pushed
the
thomas-kno-11523-sdk-clean-up-trackdebugparams-once-we-ship-toolbar-v2
branch
from
09c169d to
9b4db11
Compare
thomaswhyyou
changed the title
Base automatically changed from
thomas-kno-12634-toolbar-rename-stageresults-keys-to-bykey-and-bytype
to
main
April 14, 2026 16:19
thomaswhyyou
force-pushed
the
thomas-kno-11523-sdk-clean-up-trackdebugparams-once-we-ship-toolbar-v2
branch
from
9b4db11 to
dce6024
Compare
thomaswhyyou
commented
Apr 21, 2026
|
|
||
| export const checkActivatable = ( | ||
| guide: KnockGuide, | ||
| guide: Pick<KnockGuide, "activation_url_rules" | "activation_url_patterns">, |
Contributor
Author
There was a problem hiding this comment.
Small unrelated thing: loosen the type requirement to allow potentially re-using it in dashboard.
Contributor
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 1e1ac36. Configure here.
thomaswhyyou
requested review from
a team,
MikeCarbone and
kylemcd
and removed request for
a team
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #960 +/- ##
==========================================
- Coverage 63.82% 63.54% -0.28%
==========================================
Files 210 208 -2
Lines 10133 9921 -212
Branches 1304 1278 -26
==========================================
- Hits 6467 6304 -163
+ Misses 3641 3592 -49
Partials 25 25
|
kylemcd
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the guide toolbar "v1" from
KnockGuideToolbar, and associated downstream code in the guide client.Also removes the "guide.live_preview_updated" socket event and its handlers, now that the "Live preview" feature is deprecated and being removed (see https://github.com/knocklabs/switchboard/pull/6137).